Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

472 ct pass #2

Merged
merged 8 commits into from
Aug 15, 2021
Merged

472 ct pass #2

merged 8 commits into from
Aug 15, 2021

Conversation

Kangji
Copy link
Owner

@Kangji Kangji commented Aug 15, 2021

JIRA: NEMO-472: Fix and Implement Hierarchical Aggregation

Major changes:

  • Added new type of communication channel(Partial Shuffle)
  • Implemented pass that inserts accumulator vertex, which performs hierarchical aggregation during shuffle.
  • Implemented unit tests

Minor changes to note:

  • None

Tests for the changes:

  • Tested on my Mac and ubuntu machine

Other comments:

  • Network hierarchy information is in bin/network_profiling/labeldict.json
    (See PR#315)
  • Currently, data transfer on partial shuffle communication channel is exactly same with shuffle. It must be implemented.
  • Need more conditions when applying pass.

@Kangji Kangji merged commit 4f137a5 into 472-intermediate-combine Aug 15, 2021
@Kangji Kangji deleted the 472-ct-pass branch August 15, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant